Last modified: 2010-05-15 16:03:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16771, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14771 - Thumbnail links to individual DjVu pages have two "page" GET parameters
Thumbnail links to individual DjVu pages have two "page" GET parameters
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
DjVu (Other open bugs)
1.13.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-09 18:09 UTC by Peter Schlömer (dapete)
Modified: 2010-05-15 16:03 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Peter Schlömer (dapete) 2008-07-09 18:09:26 UTC
When including a specific page of a DjVu image, the link to the image description has two "page" GET parameters. The "zoom" symbol links to the correct URL:

http://de.wikipedia.org/w/index.php?title=Bild:Katia.djvu&page=10

The thumbnail links to this URL:

http://de.wikipedia.org/w/index.php?title=Bild:Katia.djvu&page=10&page=10

The same applies to the previous/next page preview on the image description; the thumbnails link to "&page=9&page=9" and "&page=11&page=11" in this example.

----

I don't have a test wiki at the moment, so I couldn't try to fix this myself. But I found a clue - which might help to at least solve the latter part of the problem - in /includes/ImagePage.php, lines 381-383 (and something similar for $thumb2 in 390-392):

$link = $sk->makeKnownLinkObj( $this->mTitle, $label, 'page='. ($page-1) );
$thumb1 = $sk->makeThumbLinkObj( $this->mTitle, $this->displayImg, $link, $label, 'none',
     array( 'page' => $page - 1 ) );

$link already includes "page=...", so the makeThumbLinkObj call contains this information twice. That might explain the duplication.
Comment 1 Chad H. 2009-03-13 15:02:43 UTC
Fixed in r48378
Comment 2 Chad H. 2009-03-13 15:04:44 UTC
(In addition: the first issue is what I fixed. The latter seems like it has already been fixed)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links