Last modified: 2008-08-07 09:01:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17062, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15062 - Don't show diff on edit page if user can't review changes
Don't show diff on edit page if user can't review changes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-06 21:33 UTC by Victor Vasiliev
Modified: 2008-08-07 09:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (544 bytes, patch)
2008-08-06 21:33 UTC, Victor Vasiliev
Details

Description Victor Vasiliev 2008-08-06 21:33:35 UTC
Created attachment 5130 [details]
Proposed patch

Diffs on edit page which shows changes between the last reviewed and actual version are pointless for non-reviewers, since such users can't review them anyway and they usually have a large size even for small diffs (which can be significant on large articles; note that it was a real complain from dial-up user).
Comment 1 Aaron Schulz 2008-08-07 03:27:20 UTC
The main point is to explain the discrepancies between the version they saw (stable) and the text they see when they click 'edit'.
Comment 2 Melancholie 2008-08-07 05:53:50 UTC
@Aaron: This only applied for the old configuration on de. With the current configuration the user sees the draft version by default. Even then he/she will get a diff on edit.

Show diffs only if user came from stable=1, I would say.
Comment 3 Melancholie 2008-08-07 05:58:13 UTC
@vasilvv: Note that the address http://de.wikipedia.org/w/index.php?title=L%C3%A4ssig&stable=1 is likely to be linked from outside, so diffs should still occur if a user/IP edits a page from stable=1 as starting point (if latest rev isn't flagged).
Comment 4 Aaron Schulz 2008-08-07 09:01:50 UTC
Fixed in r38757 per comment #2

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links