Last modified: 2011-03-13 18:06:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17501, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15501 - Editing defaults to not set the bot flag
Editing defaults to not set the bot flag
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.12.x
All All
: Lowest normal with 1 vote (vote)
: ---
Assigned To: X!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-06 19:52 UTC by Michael Holzt
Modified: 2011-03-13 18:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Fix (638 bytes, patch)
2008-09-06 19:58 UTC, X!
Details
That didn't help at all... (613 bytes, patch)
2008-09-06 20:06 UTC, X!
Details

Description Michael Holzt 2008-09-06 19:52:43 UTC
When editing with a user account which has the bot flag enabled, the edit is made without bot flag if not explicitly requested by adding the parameter bot to the request. In my opinion the default should be the normal use case and that is to make the edit with bot flag which is also the behaviour of the webinteface.
Comment 1 X! 2008-09-06 19:58:05 UTC
Created attachment 5298 [details]
Fix
Comment 2 Roan Kattouw 2008-09-06 19:59:37 UTC
If you want your edit saved as bot, just set the bot parameter. If you don't have permission to mark edits as bot, it'll be silently ignored anyway.
Comment 3 Dan Collins 2008-09-06 20:01:29 UTC
Shouldn't editing via the API have the same defaults as editing via the web interface?
Comment 4 Michael Holzt 2008-09-06 20:04:11 UTC
I disagree with the "WONTFIX". This behaviour of the API is reverse of what the
webinterface does and contrary to intuition. I strongly feel that the API
should by default behave in the way which makes the most sense / is the natural
one and for a bot with flag this is to make the edit with bot flag. Having said
that the flag should probably have been named "nobot".
Comment 5 X! 2008-09-06 20:06:10 UTC
Created attachment 5299 [details]
That didn't help at all...
Comment 6 Roan Kattouw 2008-09-06 20:50:42 UTC
(In reply to comment #5)
> Created an attachment (id=5299) [details]
> That didn't help at all...
> 

That patch makes it impossible *not* to mark edits as bot, so it's unacceptable.

(In reply to comment #3)
> Shouldn't editing via the API have the same defaults as editing via the web
> interface?
> 

Not necessarily. The point is that the API is aimed at bots, not users. A 'nobot' flag is counter-intuitive because everything in the API is in the opt-in style: nothing happens unless you say so (this also applies to e.g. the parameters for action=block: the UI enables some of those by default, but bots have to specify exactly what they want).

By the way, adding a &bot flag to every request is no trouble at all if you're a bot.
Comment 7 X! 2008-09-06 21:08:37 UTC
I realized that it was broken right after I posted it.
Comment 8 X! 2008-09-06 21:08:57 UTC
I realized that it was broken right after I posted it.
Comment 9 Dan Collins 2008-09-06 21:10:03 UTC
Unless you're a lazy bot, but I see your point :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links