Last modified: 2008-12-25 00:25:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18724, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16724 - exclamation mark on RC
exclamation mark on RC
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-20 16:05 UTC by Leinad
Modified: 2008-12-25 00:25 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Leinad 2008-12-20 16:05:32 UTC
On Special:RecentChanges pages from namespaces without FlaggedRevs appear with a red exclamation marks. A few days ago exclamation marks appears only with allowed namespaces of reviewable pages ($wgFlaggedRevsNamespaces).

Now RC are illegible.

I propose restore changes.
Comment 1 Aaron Schulz 2008-12-20 18:41:45 UTC
What wiki is this?
Comment 2 Leinad 2008-12-20 19:22:07 UTC
pl.wiki

We allow for reviewing only articles and templates, but now red exclamation marks also appears with category, user namespace etc.
Comment 3 Aaron Schulz 2008-12-21 09:46:37 UTC
Should be fixed in r44869
Comment 4 Leinad 2008-12-23 00:21:41 UTC
I'm not sure is it works fine...

On http://tools.wikimedia.pl/~leinad/testwiki I've got the same configuration of FlaggedRevs like on pl.wiki and I've just downloaded from SVN the latest revision of FR. Red exclamation marks still appears with not allowed namespaces of reviewable pages.

And second problem:
On RC and Watchlist filters have got wrong titels: "Hide/Show patrolled edits" -> "Hide/Show reviewed edits".
Comment 5 Aaron Schulz 2008-12-23 09:32:53 UTC
This is not retroactive.

New edits out of patrollable namespaces are automatically marked as patrolled, so they don't have marks on recent changes. Edits that already have been made would need a script to set rc_patrolled=1 to remove the marks. Either way, they will fall out of rotation like all RC items do as they get old.
Comment 6 Aaron Schulz 2008-12-24 00:20:52 UTC
Site synced. New RC items should not have ! marks.
Comment 7 Leinad 2008-12-24 01:42:40 UTC
Ok, new edits out of patrollable namespaces are automatically marked as patrolled, but created new pages still appears with ! marks.

Examples:
(różn.) (hist.) . . N! Wikipedysta:Vol de nuit‎; 01:32:02 . . (+49) . . Vol de nuit (dyskusja | edycje | zablokuj) (Nowa strona: Wikipédia France)

(różn.) (hist.) . . N! Kategoria:Ludzie związani z Wojskiem Polskim‎; 01:32:13 . . (+52) . . Poznaniak1975 (dyskusja | edycje | zablokuj) (Nowa strona: Kategoria:Biografie Kategoria:Wojsko Polskie)


And can you improve on RC and Watchlist name of filter: "Hide/Show patrolled edits" to "Hide/Show reviewed edits"?
Comment 8 Aaron Schulz 2008-12-24 01:51:27 UTC
wgUseNPPatrol is on by default, so new pages will still start off with ! marks.

A reviewed edit is also "patrol", so to speak, so I'm not to worried about "Hide/Show patrolled edits". You can go to special::allmessages to change it though (well, a Sysop can).
Comment 9 Leinad 2008-12-24 02:15:59 UTC
IMHO $wgUseNPPatrol should has got value 'false' when wiki enable FlaggedRevs.

When community decide enable FR, they discuss what namespaces they want checking for vandalism. Not allowed namespaces are not improtant, so there's no use to marking new pages as patrolled.
Comment 10 Roan Kattouw 2008-12-24 13:43:29 UTC
(In reply to comment #9)
> IMHO $wgUseNPPatrol should has got value 'false' when wiki enable FlaggedRevs.
> 
> When community decide enable FR, they discuss what namespaces they want
> checking for vandalism. Not allowed namespaces are not improtant, so there's no
> use to marking new pages as patrolled.
> 

If it annoys you, you can always try to get community consensus to get $wgUseNPPatrol disabled.
Comment 11 Aaron Schulz 2008-12-25 00:25:50 UTC
Marking this bug as closed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links