Last modified: 2008-12-26 10:27:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18796, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16796 - Impossible to edit page
Impossible to edit page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
PC Linux
: Normal blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-12-26 00:40 UTC by Bertrand GRONDIN
Modified: 2008-12-26 10:27 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch (448 bytes, patch)
2008-12-26 00:53 UTC, Brad Jorsch 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Bertrand GRONDIN 2008-12-26 00:40:58 UTC 
When I validate an edit a page, I've the following message critical error : 
Parse error: syntax error, unexpected ')' in /var/www/wiki/extensions/NewUserNotif/NewUserNotif.class.php on line 99

Impossible to access to Special:specialpages, too

Il faudrait arrêter de jouer aux apprentis sorciers.
Comment 1 Bertrand GRONDIN 2008-12-26 00:41:24 UTC 
Version mediawiki : 45041
Comment 2 Brad Jorsch 2008-12-26 00:49:36 UTC 
This appears to be a bug in the NewUserNotif extension, and not the MediaWiki core. Changing component accordingly.
Comment 3 Brad Jorsch 2008-12-26 00:53:11 UTC 
Created attachment 5623 [details]
Patch

It appears to be an extraneous comma introduces in r45017.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-12-26 01:23:15 UTC 
What version of PHP is this?  If an extra comma causes fatal errors in some versions, we have a lot of code to clean up -- we use those all over the place.
Comment 5 Brad Jorsch 2008-12-26 01:29:35 UTC 
I tested it with 5.2.6 (actually 5.2.6-0.1+b1 with Suhosin-Patch 0.9.6.2 from Debian). Extra commas are apparently allowed in arrays, but not in function parameter lists.
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-12-26 01:39:50 UTC 
Ah, there wasn't enough context in the diff for me to see that that was a function call.  That makes sense, then.  Fixed in r45042.
Comment 7 Bertrand GRONDIN 2008-12-26 10:27:43 UTC 
It runs now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links