Last modified: 2014-08-22 12:32:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18876, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16876 - cleanupImages.php should enforce same file naming rules as UploadBase
cleanupImages.php should enforce same file naming rules as UploadBase
Status: NEW
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.24rc
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-01-04 02:44 UTC by Ilmari Karonen
Modified: 2014-08-22 12:32 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ilmari Karonen 2009-01-04 02:44:52 UTC 
Currently, the maintenance/cleanupImages.php script will happily move files to names that would not be permitted for new uploads.  Most glaringly, the current implementation of ImageCleanup::buildSafeTitle() may deliberately insert backslashes into file names, even though wfBaseName(), as called from UploadBase::getTitle() via wfStripIllegalFilenameChars(), explicitly says that "we don't want \s in our [...] paths".
Comment 1 Andre Klapper 2014-08-22 12:32:36 UTC 
Confirming that ./includes/upload/UploadBase.php calls wfStripIllegalFilenameChars while ./maintenance/cleanupImages.php does not.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links