Last modified: 2009-04-05 10:36:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19225, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 17225 - GenericEditPage breaks Show Preview and Show Changes


Summary:	GenericEditPage breaks Show Preview and Show Changes

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Uniwiki (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Robert Leverington

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-01-29 12:45 UTC by Mikel Maron
Modified:	2009-04-05 10:36 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mikel Maron 2009-01-29 12:45:04 UTC

Clicking "Show Preview" is the same as toggling between Generic and Classic Mode.
Clicking "Show Changes" always goes to Classic Mode.

Comment 1 Mikel Maron 2009-03-06 14:41:47 UTC

FYI, I've found the source of this bug and applied this patch. Looks like some php installations will set switch-mode even if it's submitted empty.

@@ -705,7 +707,7 @@
      * pressing the "switch mode" button, then
      * set a global to do some jiggery-pokery
      * in the displayEditPage function, later */
-    if ( isset( $data['switch-mode'] ) )
+    if ( isset( $data['switch-mode'] ) and strlen( $data['switch-mode']) > 0)
         $wgSwitchMode = true;

Comment 2 Mark Johnston 2009-03-06 21:16:13 UTC

mikel's patch has been applied in rev #48098, not sure if i should mark this as closed yet...

Comment 3 Robert Leverington 2009-04-05 10:36:05 UTC

This bug is fixed in trunk.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links