Wikimedia Bugzilla is closed!

Created attachment 5901 [details]
Small Patch

I made this small patch, but this only fixes the Problem inside factboxes but has no effect on inline-query output

Well the behaviour is really strange because every null-edit changes the output

Another thig is that the getShortWikiText and getShortHTMLText is a bit strange to me

if ( ($linked === NULL) || ($linked === false) || ($this->m_url == '') || ($this->m_caption == '') ) {
	return $this->m_caption;

Is this right that when m_caption is empty m_caption is printed?

Created attachment 5902 [details]
Patch for Type Email

So now it works. DB stores E-Mail without mailto: (save some resource) mailto: is given by type Mail

The output works the way that mailto: is added to E-Mail URL and the visible value is the one storred in Database

(In reply to comment #2)
> Well the behaviour is really strange because every null-edit changes the output
> 
> Another thig is that the getShortWikiText and getShortHTMLText is a bit strange
> to me
> 
> if ( ($linked === NULL) || ($linked === false) || ($this->m_url == '') ||
> ($this->m_caption == '') ) {
>         return $this->m_caption;
> 
> Is this right that when m_caption is empty m_caption is printed?
> 

Yes, this is how it is possible to hide annotations by giving only a space as alternative text.

(In reply to comment #3)
> Created an attachment (id=5902) [details]
> Patch for Type Email
> 
> So now it works. DB stores E-Mail without mailto: (save some resource) mailto:
> is given by type Mail
> 
> The output works the way that mailto: is added to E-Mail URL and the visible
> value is the one storred in Database
> 

This does not work yet: it breaks the RDF export (where mailto: is needed, too). I need to consider this carefully; changing the DB contents is always a bit tricky (everybody needs to refresh the DB on upgrade!), and modifying the default representation may break other features unexpectedly. But I think that it is doable.

I have now fixed this in SVN. "mailto:" is optional in all email inputs, and it is generally omitted in outputs.