Last modified: 2009-03-26 01:30:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20153, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 18153 - Patch radixRegex overmatching
Patch radixRegex overmatching
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-03-25 17:02 UTC by Robert Rohde
Modified: 2009-03-26 01:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch to prevent radixRegex catching empty strings (523 bytes, patch)
2009-03-25 17:02 UTC, Robert Rohde 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Robert Rohde 2009-03-25 17:02:42 UTC 
Created attachment 5960 [details]
patch to prevent radixRegex catching empty strings

This was included in a previous patch but overlooked in the merging.

radixRegex in AbuseFilterParser::nextToken currently throws empty string matches against non-numeric data.  Those matches are later discarded by another part of the code, but because it is overmatching the number finding code profiles as the 2nd or 3rd most expensive block in nextToken even though numbers are relatively rare.

The attached patch prevents empty string matches.
Comment 1 Andrew Garrett 2009-03-26 01:30:27 UTC 
r48848
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links