Last modified: 2013-12-18 12:58:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20245, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18245 - AutoCreateCategoryPages unable to detect category links embedded in templates that depends on template parameters
AutoCreateCategoryPages unable to detect category links embedded in templates...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AutoCreateCategoryPage (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Dror S.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-29 22:11 UTC by conanchristie
Modified: 2013-12-18 12:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch 1 (29.00 KB, patch)
2009-03-29 22:11 UTC, conanchristie
Details
svn-style patch (4.28 KB, patch)
2009-06-09 21:41 UTC, conanchristie
Details

Description conanchristie 2009-03-29 22:11:59 UTC
Created attachment 5976 [details]
Proposed patch 1

Although this extension works fine for category links in normal wikitext and simple links embedded in transcluded templates, I found out that if the embedded link was dependent to template parameters, e.g. [[Category:Foo in {{{1}}}]], the extension no longer detects the link and hence did not make the stub page.

I found out that the extension relies on a regex match of /\[\[{$category}:(.+?)(?:\|.*)?\]\]/i to determine catlinks at hook ArticleSaveComplete. Hence, the processing was too early to allow parser to parse the templates to create the correct catlinks, nor does the regex very accurate. The regex itself also caused the fixme about being en-specific, as it did not adequately deal with renamed namespaces.

So I changed the hook to ArticleAfterFetchContent (after parsing), and the detection of catlinks is now through querying the categorylinks table.

Needs to be reviewed; I'm a complete newbie in all this stuff.
Comment 1 Siebrand Mazeland 2009-06-01 18:05:54 UTC
This is not a patch. These are complete files. Please provide a proper patch.
Comment 2 conanchristie 2009-06-09 21:41:36 UTC
Created attachment 6213 [details]
svn-style patch

Made into SVN-style patch per Siebrand's comment. Also based the patch on the current version (51662).
Comment 3 Andre Klapper 2013-04-16 08:53:04 UTC
According to one of its developer (Mark), Uniwiki extensions for MediaWiki are not under active development anymore "and it is safe to declare them obsolete/wontfix."

It is unlikely that there will be any further active development.

Closing this report as WONTFIX as part of Bugzilla Housekeeping and adding the whitespace entry "extension[unmaintained]". Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.
Comment 4 Dror S. 2013-12-15 15:56:58 UTC
I have taken over the maintenance of this extension. It now works with MW 1.21+ (probably with previous versions as well), resides in git, and as part of the cleanup I have apparently fixed this bug. I was completely unaware of this bug report up until now... so I'm marking it as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links