Last modified: 2009-10-21 08:17:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22847, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20847 - Remove deprecated akeytt()
Remove deprecated akeytt()
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-28 12:28 UTC by Derk-Jan Hartman
Modified: 2009-10-21 08:17 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Remove akeytt() function (2.74 KB, patch)
2009-09-28 12:36 UTC, Derk-Jan Hartman
Details
Remove akeytt() function, but leave dummy (2.75 KB, patch)
2009-09-28 23:27 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2009-09-28 12:28:09 UTC
I think it is about time we truly removed akeytt() from wikibits.js. This function to update the tooltips and add keyboard shortcuts for them has been deprecated for a while. I have a patch that removes it, but I need to repair ajaxwatch.js which abuses this function.

Does anyone think we should provide a "dummy" function so that other scripts that are potentially using this function won't break ?
Comment 1 Derk-Jan Hartman 2009-09-28 12:36:20 UTC
Created attachment 6593 [details]
Remove akeytt() function

ajaxwatch was using akeytt. However it was never updating the tooltip on wiki's that were not using the old ta Object to add tooltips and accesskeys. By now, that would be almost any wiki.

As such this updating of the tooltip functionality was broken on almost all wiki's and I consider it to be a separate issue if it needs fixing.
Comment 2 Brion Vibber 2009-09-28 19:06:43 UTC
Might be best to leave an empty stub function; that way any old scripts that call it will still run, just they won't get their tooltips added.
Comment 3 Derk-Jan Hartman 2009-09-28 23:27:10 UTC
Created attachment 6597 [details]
Remove akeytt() function, but leave dummy

Same patch, but now leaving a dummy function in place.
Comment 4 Siebrand Mazeland 2009-10-21 08:17:00 UTC
Applied in r57968. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links