Last modified: 2014-07-09 10:05:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22870, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20870 - Sitenotice should be parsed in context of [[MediaWiki:Sitenotice]], not of the page below
Sitenotice should be parsed in context of [[MediaWiki:Sitenotice]], not of th...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.16.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-29 09:09 UTC by Roan Kattouw
Modified: 2014-07-09 10:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2009-09-29 09:09:11 UTC
It seems that when parsing the sitenotice, the page it's shown on top of is used as parsing context (for {{PAGENAME}} etc.). I know you can't count on {{PAGENAME}} and friends to be meaningful in the sitenotice due to heavy caching, but there are more problems with parsing in the context of a random title:

1. Subpage links like [[/foo]] don't point to [[MediaWiki:Sitenotice/foo]] but to [[Somerandompage/foo]] (if subpages are even enabled in the namespace in question)
2. Links to other pages will show up as selflinks if it so happens that the sitenotice was reparsed while on top of the target page. This happened on fiwiki today
Comment 1 T. Gries 2011-01-28 06:53:49 UTC
(In reply to comment #0 2009-09-29)
> It seems that when parsing the sitenotice, the page it's shown on top of is
> used as parsing context (for {{PAGENAME}} etc.). I know you can't count on
> {{PAGENAME}} and friends to be meaningful in the sitenotice due to heavy
> caching, but there are more problems with parsing in the context of a random
> title: ...
> 2. Links to other pages will show up as selflinks if it so happens that the
> sitenotice was reparsed while on top of the target page. This happened on
> fiwiki today

I can confirm this bug: it happened for one of my wikis (MW 1.15.1) today (2011-01-28), too (link in sitenotice to another page was rendered as self link, as if you are on that page).
Comment 2 T. Gries 2011-01-28 07:08:10 UTC
On the other hand - when viewing or editing the target page x - even after refreshing, the sitenotice does not render the link to the (same) target page x as self link, but should do so. Seen on MW 1.16.1 installation.
Comment 3 T. Gries 2011-06-13 16:07:24 UTC
It could be fixed easily, but there may be cache issues (I am not an expert in these cache things).

Can the experts please comment on this bug, or fix that?
Comment 4 contrafibularity 2014-07-09 09:48:17 UTC
It's 2014 now and the request for a fix is still standing for MW 1.23. Should a separate report be filed for this MediaWiki version?
Comment 5 Andre Klapper 2014-07-09 10:05:19 UTC
(In reply to contrafibularity from comment #4)
> It's 2014 now and the request for a fix is still standing for MW 1.23.
> Should a separate report be filed for this MediaWiki version?

No. First there needs to be a fix for git master. After that exists, a "request to backport" flag can be set to backport it to 1.23.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links