Last modified: 2010-01-22 14:54:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24222, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22222 - E-Mail notification message text enotif_body needs to be updated (patch)
E-Mail notification message text enotif_body needs to be updated (patch)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-21 23:45 UTC by T. Gries
Modified: 2010-01-22 14:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
diff patch (783 bytes, patch)
2010-01-21 23:46 UTC, T. Gries
Details

Description T. Gries 2010-01-21 23:45:27 UTC
Since the introduction in REL_1.6 in 2006, the e-mail notification message body template remained unchanged. Now it is possible to improve the message template by using newer internal variables. (Module UserMailer.php could be deliberately modified accordingly, so to skip calculation of the now-unneeded variable $PAGETITLE and $PAGETITLE_URL)

I also added a direct link for action=unwatch in the mail footer which helps users to immediately stop watching without visiting that page (in case they want to stop further notifications for that page).
Comment 1 T. Gries 2010-01-21 23:46:08 UTC
Created attachment 7004 [details]
diff patch
Comment 2 Platonides 2010-01-21 23:54:02 UTC
The {{FULLPAGENAME}} are in fact more costly than $PAGETITLE (which should still be accepted for bc).


> I also added a direct link for action=unwatch in the mail footer which helps
> users to immediately stop watching without visiting that page (in case they
> want to stop further notifications for that page).

Is it really needed? "There will be no other notifications in case of further changes unless you visit this page.", and there's already a link to Special:Watchlist/edit. I'm unsure about it.

Thanks for your contribution anyway.
Comment 3 T. Gries 2010-01-22 00:04:46 UTC
I (as co-contributor of Enotif) find it very useful to have a direct link to unwatch a page. 

As mentioned, it saves any further viewing of pages or watchlist access, thus it is a perfect single-click solution to "get rid" of obsolete watches at the moment you receive a notification (try it: on commons and on mediawiki, the E-Mail notification is enabled). Because the url and the action is clear, almost no further processing load is needed.

Moreover, the proposed additional unwatch line can by easily removed by editing  MediaWiki:Enotif_body if wanted by a sysop. That's my rationale to propose it now as a useful addition.
Comment 4 T. Gries 2010-01-22 00:09:51 UTC
(In reply to comment #2)
> The {{FULLPAGENAME}} are in fact more costly than $PAGETITLE (which should
> still be accepted for bc).

I was _not_ aware of this fact, but to have two different things for the same result isn't that nice, is it? When it was designed, I had no other chance of self-calculation $PAGETITLE and $PAGETITLE_URL . 

So, I would agree, to let the message as it is (and to close this bug as NOFIX).
Comment 5 Platonides 2010-01-22 14:54:02 UTC
Added the unwatch link on r61367

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links