Last modified: 2011-03-13 18:06:23 UTC
Created attachment 7333 [details] Move EXPLAIN functionality from DatabaseBase::selectSQLText to inheriting DatabaseMysql class EXPLAIN is implemented in different ways across different RDBMS. The current implementation of DatabaseBase::selectSQLText assumes we're using MySQL. Move this part of the abstract function to the specific DB that uses it in order to free up the abstract function to be inherited by other DB classes. Patch provided to do just this.
Provided that no other DBMSes use this, feel free to go ahead and commit this.
EXPLAIN is also used by PG and Oracle, this patch will apparently break them.
To reduce code duplication, instead of overriding it in several classes, just rewrite it in DatabaseMssql, something like http://pastebin.com/QwrxLc3E
Created attachment 7334 [details] Move EXPLAIN functionality to child classes Also touches DatabaseOracle and DatabasePostgres, fixes syntax error.
Closing and changing this to "won't fix". MaxSem's solution works well and doesn't touch as much code, so I'll implement it. Thanks. -yaauie
