Last modified: 2010-07-28 21:58:30 UTC
When the "Enable enhanced search suggestions (Vector skin only)" option is disabled, the suggestion dropdown doesn't appear. This is because the code in SimpleSearch.js runs regardless of the setting, and it activates the enhanced search suggestions, but because the simpleSearch div is missing from the output, the suggestion dropdown isn't positioned correctly and it is not visible. If I'm not mistaken, this part: if( !wgVectorEnabledModules.simplesearch || wgVectorPreferences.simplesearch.disablesuggest || skin != 'vector' ) { return true; } needs to also check for !wgVectorPreferences.simplesearch.enable
*** Bug 23823 has been marked as a duplicate of this bug. ***
(In reply to comment #0) > If I'm not mistaken, this part: > > if( !wgVectorEnabledModules.simplesearch || > wgVectorPreferences.simplesearch.disablesuggest || skin != 'vector' ) { > return true; > } > > needs to also check for !wgVectorPreferences.simplesearch.enable This looks like it's the culprit; Adam, could you handle this?
i added it...r70117. Not sure it was needed, but it also doesn't seem to break anything.