Last modified: 2014-01-23 17:24:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26451, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24451 - Test case failure in UTF-8 normalization: CleanupTest.php
Test case failure in UTF-8 normalization: CleanupTest.php
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.17.x
All All
: Low major (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-19 20:08 UTC by Brion Vibber
Modified: 2014-01-23 17:24 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2010-07-19 20:08:24 UTC
This is a bit worrying, since the given case is one of the most important ones -- UtfNormal::cleanUp() is supposed to normalize combining characters, and here it's not tripping correctly.

Not quite sure why this is failing, needs investigation.

The recent commit w/ iconv support doesn't seem to be tripping the issue for me. Tested so far w/ PHP 5.2 & 5.3 custom-built on Mac OS X 10.6.

$ /opt/php52/bin/php CleanUpTest.php 
PHPUnit 3.4.15 by Sebastian Bergmann.

...F..........

Time: 11 seconds, Memory: 8.75Mb

There was 1 failure:

1) CleanUpTest::testLatinNormal
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-L'école
+L'école

/Library/WebServer/Documents/trunk/includes/normal/CleanUpTest.php:79
/Library/WebServer/Documents/trunk/includes/normal/CleanUpTest.php:407

FAILURES!
Tests: 14, Assertions: 66571, Failures: 1.
Comment 1 Kevin Israel (PleaseStand) 2013-11-30 05:19:05 UTC
Brion, are you still seeing this failure, or can we mark this one RESOLVED?
Comment 2 Andre Klapper 2014-01-23 15:31:24 UTC
Brion: Could you please answer comment 1?
Comment 3 Brion Vibber 2014-01-23 15:49:09 UTC
PHPUnit 3.7.0 or later required, you have 3.6.12.

wheeeeee

I'll let you know when I get that resolved.
Comment 4 Brion Vibber 2014-01-23 15:54:47 UTC
Ok, so installing PHPUnit 3.7 doesn't appear to remove the hidden-somewhere 3.6.12 so I can't test this.
Comment 5 Brion Vibber 2014-01-23 15:59:48 UTC
Ok got that resolved; somehow had two PEAR installs, and the one that things installed to wasn't the one being used. Sigh.

$ php phpunit.php includes/normal/CleanUpTest.php 
PHPUnit 3.7.29 by Sebastian Bergmann.

Configuration read from /Library/WebServer/Documents/core/tests/phpunit/suite.xml

...............

Time: 628 ms, Memory: 11.75Mb

OK (15 tests, 17420 assertions)

I'll consider this a worksforme.
Comment 6 Antoine "hashar" Musso (WMF) 2014-01-23 17:24:22 UTC
Thanks Brion!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links