Last modified: 2014-03-08 08:13:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26866, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24866 - Rollbacks improperly reported under race condition
Rollbacks improperly reported under race condition
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.17.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-19 05:23 UTC by Cobi
Modified: 2014-03-08 08:13 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Fixes bug. (438 bytes, patch)
2010-08-19 05:23 UTC, Cobi 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Cobi 2010-08-19 05:23:54 UTC 
Created attachment 7637 [details]
Fixes bug.

Rollbacks can be improperly reported under certain race conditions.  Mainly because the doEdit call's status is never checked before notifying of a successful rollback.

The diff should fix this.

--Cobi.
Comment 1 Liangent 2010-08-19 05:32:48 UTC 
Using the message "Cannot revert edit; last contributor is only author of this page." is bad. A new message should be added.
Comment 2 Sam Reed (reedy) 2010-08-19 09:27:10 UTC 
Also,
You should really have it with braces as per the coding style guidelines

if( !$status->isOK() ) {
	return array( array( 'cantrollback' ) );
}
Comment 3 Bryan Tong Minh 2011-05-14 14:20:38 UTC 
Marking as reviewed per comment #2.
Comment 4 db [inactive,noenotif] 2014-03-08 08:13:27 UTC 
Check for $status->isOk was added with Gerrit change #21662
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links