Last modified: 2013-12-15 20:52:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27298, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25298 - Link to [[Special:PendingChanges]] from sidebar if logged in user is reviewer
Link to [[Special:PendingChanges]] from sidebar if logged in user is reviewer
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Wikipedi...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-25 02:44 UTC by Rob Lanphier
Modified: 2013-12-15 20:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Lanphier 2010-09-25 02:44:05 UTC
See http://en.wikipedia.org/wiki/Wikipedia:Pending_changes/Feedback/Archive_2#Side_bar_link

It's conceivable that there should be a link in the "Toolbox" for those with Reviewer rights.  This issue is about figuring out if it's appropriate.
Comment 1 Platonides 2010-09-28 17:04:32 UTC
I don't think so. We don't have actions in the toolbox. I think that if added, It should go as a tab.
Comment 2 Rob Lanphier 2010-10-08 03:27:05 UTC
Quoting the relevant portion of this email:
http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/049813.html

We're probably not going to address this one in the November 2010
release.  If we do it, we need to make it conditional upon whether the
person has reviewer rights.  The problem with this one is that we
don't yet have clear guidelines for what belongs in the toolbox on the
left, and whether any of the pending changes special pages rise to the
level of importance that we should put them in the toolbox.
Comment 3 Chad H. 2010-10-08 05:10:52 UTC
(In reply to comment #2)
> Quoting the relevant portion of this email:
> http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/049813.html
> 
> We're probably not going to address this one in the November 2010
> release.  If we do it, we need to make it conditional upon whether the
> person has reviewer rights.  

This is entirely trivial. 

> The problem with this one is that we
> don't yet have clear guidelines for what belongs in the toolbox on the
> left, 

There aren't any guidelines. Extensions are free to add things to the toolbar.

> and whether any of the pending changes special pages rise to the
> level of importance that we should put them in the toolbox.

No opinion here one way or the other.
Comment 4 Rob Lanphier 2010-10-14 23:59:35 UTC
Ok, here's the plan.  We'll link from the toolbox to [[Special:PendingChanges]] (nee [[Special:OldReviewedPages]]) *if* the logged in user has review permission.

Unassigning from Brandon for now.  Will assign to a developer next time we triage.
Comment 5 Rob Lanphier 2010-11-29 22:00:52 UTC
Unassigning for now....this might end up going right back to Priyanka
Comment 6 Aaron Schulz 2010-11-30 19:46:49 UTC
Aside from "Special pages", all of the toolbox items are relevant to the page being viewed. This probably should go elsewhere if anywhere. Maybe even "Special pages" should be moved eventually...
Comment 7 Rob Lanphier 2010-11-30 20:27:08 UTC
"Upload" is also not specific to the page being viewed.  That said, it makes the most sense in proximity to "Recent changes", which is under "Interaction" in Vector, so that seems like the best place to put it, IMHO.
Comment 8 Aaron Schulz 2010-11-30 20:48:58 UTC
(In reply to comment #7)
> "Upload" is also not specific to the page being viewed.  That said, it makes
> the most sense in proximity to "Recent changes", which is under "Interaction"
> in Vector, so that seems like the best place to put it, IMHO.

Maybe Brandon should look at this? Having the link there feels awkward. It might be better under "Interaction" or something.
Comment 9 Aaron Schulz 2010-12-20 22:27:28 UTC
One problem with using navigation/interaction is that buildSidebar() uses a cache that is only language dependent. Adding the link only for Reviewers would result in cache pollution and wouldn't work.

The toolbox doesn't have this problem, but it's an awkward place though.
Comment 10 Priyanka Dhanda 2010-12-21 19:45:14 UTC
Yeah, I'm not sure how to make the link visible only for reviewers. According to Roan, this is the correct way to customize the sidebar:
https://secure.wikimedia.org/wikipedia/en/w/index.php?title=MediaWiki:Sidebar&action=edit
Comment 11 Platonides 2010-12-22 00:26:02 UTC
Priyanka, you don't want to use MediaWiki:Sidebar. That's for user customizing. This would be *the software* adding it.
Comment 12 Aaron Schulz 2011-02-25 10:38:25 UTC
Is there any demand for this or should it be scrapped or something?
Comment 13 Rob Lanphier 2011-03-17 21:42:00 UTC
Making this low priority, due to the dependency on making it practical to add new items to the "Interaction" area via extension.
Comment 14 Aaron Schulz 2011-03-24 02:33:46 UTC
Also see bug 25298.
Comment 15 Aaron Schulz 2013-12-15 20:52:20 UTC
(In reply to comment #12)
> Is there any demand for this or should it be scrapped or something?

Closing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links