Last modified: 2012-12-06 20:59:51 UTC
After r74742, r74743, r74745 there are still 56 assignments in conditionals in MW phase3 Related to that r74727 was found (bug where = had been wrongly used in a comparison)
I'm not personally against them. Take http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ResourceLoader.php?view=markup#l324 for instance. I think it's clear that we aren't mistakenly doing assignment rather than comparison.
I'm not against them either, provided the code makes some attempt to show that it's not mistaking = for ==.
http://www.mediawiki.org/wiki/Manual:Coding_conventions#Assignment_expressions Turns out it's in the coding conventions...
Fair enough. I'm fine with avoiding them if we are conforming to an established standard.
(In reply to comment #0) > [..] there are still 56 assignments in conditionals Got a ack-grep regex to share?
(In reply to comment #5) Got a ack-grep regex to share? \(\s*\$[^=\n&|'");]+[^!<>=]=\s*\$[^\n)'";]+\) Looks usable