Last modified: 2010-10-18 15:15:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27535, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25535 - ResourceLoader shouldn't use empty MediaWiki:Skinname.js
ResourceLoader shouldn't use empty MediaWiki:Skinname.js
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-15 17:52 UTC by Yaron Koren
Modified: 2010-10-18 15:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yaron Koren 2010-10-15 17:52:00 UTC
If you create a new skin that uses the ResourceLoader, the code adds in the contents of the page "MediaWiki:<skin name>.js" - but if that page is blank (as it would be by default), the string "<<skin name>.js>" shows up in the page, causing a Javascript error.
Comment 1 Chad H. 2010-10-17 16:17:06 UTC
Retitling bug. The RL shouldn't add the message if it's empty.
Comment 2 Roan Kattouw 2010-10-18 15:15:42 UTC
Fixed in r74948.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links