Last modified: 2010-12-02 12:57:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28197, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26197 - Collection: bookcreator.js fails when using Resource Loader
Collection: bookcreator.js fails when using Resource Loader
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: PediaPress Development Team
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-02 07:18 UTC by Thomas Bleher
Modified: 2010-12-02 12:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thomas Bleher 2010-12-02 07:18:42 UTC
The Collection extension has a feature that when book creation is active, the user can hover over any wiki link and a popup will appear offering to add the linked page to the current book.

This feature is currently broken (using up-to-date phase3 and collection checkouts from svn). I strongly suspect that the introduction of the ResourceLoader broke this extension.

The errors in the Chromium console are:

Uncaught ReferenceError: jQuery is not defined /w/extensions/Collection/js/jquery.json.js?8:17

Uncaught ReferenceError: $ is not defined /w/extensions/Collection/js/jstorage.js?8:53

Uncaught ReferenceError: jQuery is not defined /w/extensions/Collection/js/bookcreator.js?8:22

The Collection extension asks for JQuery by calling $wgOut->includeJQuery();
but can't find it afterwards (Collection.hooks.php:257). After changing this code so the Collection extension uses its own JQuery library (which comes bundled with the extension), the error above go away, but there is a new error: 

Uncaught ReferenceError: wgServer is not defined 
/w/extensions/Collection/js/bookcreator.js?8:24

IMHO this should be fixed before the Resource Loader is deployed on Wikimedia sites.
Comment 1 Thomas Bleher 2010-12-02 07:48:27 UTC
I should add that the rest of the Collection extension (adding pages, exporting PDFs etc.) works correctly. The code is live on http://spiele.j-crew.de, so you can also look at the generated HTML.
Comment 2 Johannes Beigel 2010-12-02 12:57:41 UTC
Thanks a lot! I've committed a few small changes in r77576 which fixes the problems for me.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links