Last modified: 2012-09-29 10:52:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28325, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26325 - deleting translation from Message.php does not update to fallback
deleting translation from Message.php does not update to fallback
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
LocalisationUpdate (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-13 19:17 UTC by Umherirrender
Modified: 2012-09-29 10:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2010-12-13 19:17:08 UTC
r78013 removes key 'december' from MessagesDe_at.php, but on de.wp the message [[de:MediaWiki:December/de-at]] is not updated to the fallback.

The sync has work for other messages like [[de:MediaWiki:Htmlform-submit]] (r78138)

It is possible to update the message to the fallback, when it is removed from Message.php? Thanks
Comment 1 Umherirrender 2010-12-28 21:05:29 UTC
For information: With r79023 the key was readded to MessagesDe_at.php.
Comment 2 Umherirrender 2011-01-01 19:40:09 UTC
You have to unset a message key, when the key is in the $compare_messages (because it is in the default Message*.php or the cache from previous updates), but not in $base_messages (because the key was removed from svn). With an unset of the message key the fallback of MediaWiki should work.
Comment 3 Roan Kattouw 2011-01-01 23:38:05 UTC
(In reply to comment #2)
> You have to unset a message key, when the key is in the $compare_messages
> (because it is in the default Message*.php or the cache from previous updates),
> but not in $base_messages (because the key was removed from svn). With an unset
> of the message key the fallback of MediaWiki should work.

Sounds like this shouldn't be too hard, taking this bug.
Comment 4 Tom Maaswinkel 2011-01-01 23:47:30 UTC
this is actually a feature, not a bug. It is to prevent a message that's deleted in a newer version of MediaWiki to also be removed in older version that still use that message!
Comment 5 Roan Kattouw 2011-01-02 08:37:39 UTC
(In reply to comment #4)
> this is actually a feature, not a bug. It is to prevent a message that's
> deleted in a newer version of MediaWiki to also be removed in older version
> that still use that message!
Right...

There's a difference though between the message being deleted from trunk completely and only being deleted from one language (in the latter case, that's meant to trigger the fallback). So if a message is removed from the language we're processing but still present in English, I think we should remove it from LU too, and keep it otherwise. Sound about right?
Comment 6 Tom Maaswinkel 2011-01-02 10:09:50 UTC
That sounds like the right solution
Comment 7 Umherirrender 2012-09-29 10:52:25 UTC
Needs testing, if still a issue. Some changes to LocalisationUpdate was made in past month/year.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links