Last modified: 2011-10-11 21:37:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28744, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 26744 - Success message broken


Summary:	Success message broken

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	MultiUpload (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Lowest major (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-01-15 12:14 UTC by Gregor Hagedorn
Modified:	2011-10-11 21:37 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gregor Hagedorn 2011-01-15 12:14:31 UTC

After successfully uploading multiple files (SVN r79596) the message is a literal (I put a blank in front of the ";" to make sure it is not converted, original output is without the blank).

&lt ;successfulupload&gt ;

Some of the messages had been updated for an earlier use of multiupload, so this bug may depend on using a database-derived message rather than the native system message.

I rate this bug major, because it is the main success message and is irritating users, thinking something went wrong.

Comment 1 Travis D 2011-02-15 19:31:55 UTC

It works for me. 

successfulupload is defined in all of the messages files in languages/messages, it's not a extension specific message. 

What language did you experience this in?

Comment 2 Andreas Plank 2011-02-17 23:15:31 UTC

I am working on the same wiki, you can upload but the heading message is still broken. It seems that the system message "succesfulupload" is not defined so it puts <succesfulupload> from the php call wfMsgHtml( 'successfulupload' ) which becomes "&lt ;successfulupload&gt ;" (without spaces of course)

Should it not be "upload-success-msg" instead? This is defined.

Comment 3 Travis D 2011-02-18 01:31:48 UTC

Which Mediawiki version are you working with, and in what language?

The message is defined as successfulupload in MessagesEn.php:

> egrep successfulupload languages/messages/MessagesEn.php 
'successfulupload'            => 'Successful upload',

Comment 4 Travis D 2011-02-18 01:33:30 UTC

This definition is in Mediawiki 1.16.0.

Comment 5 Gregor Hagedorn 2011-02-18 06:50:43 UTC

http://biowikifarm.net/meta/Special:Version = 1.18alpha (r79596) -- see first message -- and http://biowikifarm.net/test/Special:Version = 1.18alpha (r82189) produce:

http://biowikifarm.net/meta/MediaWiki:Successfulupload
= empty

Comment 6 Travis D 2011-02-18 17:33:36 UTC

Looks like this was removed with this revision change:

r1=70028&r2=70138&pathrev=79596">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/languages/messages/MessagesEn.php?r1=70028&r2=70138&pathrev=79596

Unfortunately, this extension is written for 1.16, it hasn't been tested on 1.18. Since most people are using this version, I think it makes sense to keep it as is. 

To fix this bug on your own wiki, you can create a Mediawiki:successfulupload article with the contents

Successful upload

Comment 7 Gregor Hagedorn 2011-02-18 17:52:32 UTC

Just a note: this means the extension does not work on current wikipedia. I rather believe that most sites follow wikipedia

http://en.wikipedia.org/wiki/MediaWiki:Successful_upload

Comment 8 Gregor Hagedorn 2011-02-18 18:35:10 UTC

Current correct message is: upload-success-subj

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links