Last modified: 2013-03-24 21:15:54 UTC
The three foreach() loops here: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialWhatlinkshere.php?revision=80409&view=markup#l188 overwrite eachother. That was done to avoid duplicates. However the props are also overwritten. Perhaps a check to see if it's been set already should be done and merge the is_template/is_image props. Although we could choose to let one count stronger than the other (in this case imagelink, over templatelink, over pagelink) however the following code is clearly designed with the scenario in mind that multiple props could be set to 1: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialWhatlinkshere.php?revision=80409&view=markup#l292 <pre> 298 if ( $row->is_template ) 299 $props[] = $msgcache['istemplate']; 300 if( $row->is_image ) 301 $props[] = $msgcache['isimage']; 302 303 if ( count( $props ) ) { 304 $propsText = '(' . implode( $msgcache['semicolon-separator'], $props ) . ')'; 305 } </pre>
*** Bug 26903 has been marked as a duplicate of this bug. ***
Code is now at https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/specials/SpecialWhatlinkshere.php;hb=HEAD#l313 (for an potential contributors); seems to be still valid.