Last modified: 2011-03-29 23:51:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30275, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28275 - Change 0/1 to common true/false in boolean settings in DefaultSettings.php
Change 0/1 to common true/false in boolean settings in DefaultSettings.php
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-27 16:38 UTC by The Evil IP address
Modified: 2011-03-29 23:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Trivial patch (4.27 KB, patch)
2011-03-27 16:38 UTC, The Evil IP address 		Details
Add an attachment (proposed patch, testcase, etc.)

Description The Evil IP address 2011-03-27 16:38:10 UTC 
Created attachment 8336 [details]
Trivial patch

I think that boolean values in DefaultSettings.php should, for consistency, always use true or false instead of 0 or 1. Though both works, I think it's confusing for people when it differs. Not everyone might be aware that it's a boolean value when there are numbers. Simple patch added, thanks.
Comment 1 Chad H. 2011-03-27 16:39:56 UTC 
Does this break any strict comparisons?
Comment 2 Roan Kattouw 2011-03-27 17:17:56 UTC 
Preferences of the 'toggle' type (i.e. boolean preferences) are stored numerically as 0 or 1, not as false or true. Applying this patch and checking whether anything would break as a result is more trouble than it's worth IMO.
Comment 3 Mark A. Hershberger 2011-03-29 23:51:54 UTC 
WONTFIXing per Roan's "more trouble than it's worth"
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links