Last modified: 2011-04-20 12:27:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30537, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 28537 - jQuery UI button text color slightly differs from default link color


Summary:	jQuery UI button text color slightly differs from default link color

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-04-14 13:27 UTC by DieBuche
Modified:	2011-04-20 12:27 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description DieBuche 2011-04-14 13:27:12 UTC

They should be the same, imo.

Comment 1 DieBuche 2011-04-14 13:56:20 UTC

It's #2779AA; currently, link color is #0645AD;

Comment 2 Krinkle 2011-04-15 11:31:39 UTC

You mean the Vector-theme in the jQuery UI director, right ? Or the default one.

Depending on whether it's loaded through ResourceLoader it may load the default theme.

The color in the default theme should probably not be altered to make updates painless, however our jQuery UI Vector-theme should be fixed if it doesn't match.


Easy fix ?

Comment 3 Naga Srikanth J 2011-04-16 07:13:00 UTC

can anyone clearly mention the file or skin of the bug. Actually I'm not able to locate the bug.

Comment 4 DieBuche 2011-04-16 09:04:22 UTC

(In reply to comment #3)
> can anyone clearly mention the file or skin of the bug. Actually I'm not able
> to locate the bug.
/resources/jquery.ui/themes/vector/jquery.ui.theme.css, L23-26

I just tried it out, it looks better in a normal context, but it clashes with the lighter blue, when inside the wikiEditor.
Possible workaround: Make button font color black (like for nearly all native browser buttons). 
and (optionally) use the lighter blue when inside form#editform

Comment 5 Trevor Parscal 2011-04-19 22:10:07 UTC

I think it would be fine to just color it black, I don't think we gain much by having it be blue, it looks very clickable - if anything we are double-coding it (and then failing to do so by using different colors).

Comment 6 DieBuche 2011-04-20 12:27:59 UTC

Fixed in r86473

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links