Last modified: 2012-05-28 17:56:47 UTC
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83679 Failed to load expected revision data Backtrace: #0 /usr/local/apache/common-local/php-1.17/extensions/CodeReview/ui/CodeRevisionView.php(24): CodeRepository->getRevision(83679) #1 /usr/local/apache/common-local/php-1.17/extensions/CodeReview/ui/SpecialCode.php(90): CodeRevisionView->__construct('MediaWiki', '83679') #2 /usr/local/apache/common-local/php-1.17/extensions/CodeReview/ui/SpecialCode.php(24): SpecialCode->getViewFrom('MediaWiki/83679') #3 /usr/local/apache/common-local/php-1.17/includes/SpecialPage.php(578): SpecialCode->execute('MediaWiki/83679') #4 /usr/local/apache/common-local/php-1.17/includes/Wiki.php(251): SpecialPage::executePath(Object(Title)) #5 /usr/local/apache/common-local/php-1.17/includes/Wiki.php(63): MediaWiki->handleSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest)) #6 /usr/local/apache/common-local/php-1.17/index.php(114): MediaWiki->performRequestForTitle(Object(Title), NULL, Object(OutputPage), Object(User), Object(WebRequest)) #7 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...') #8 {main} It's essentially been oversighted, that and r82952, so should fallback a bit more graciously...
Missing revision data would normally be considered a serious bug as it's inconsistent with the repository state and subversion's versioning model. Requests for revisions that haven't yet been reached are handled gracefully; for those that should be in the database we throw an exception as it indicates database corruption. Are those revisions actually removed from SVN as well, and does SVN behave cleanly that way? If not, is there a possibility that some batch process will just fill them back in some day when nobody's thinking about it?
(In reply to comment #1) > Are those revisions actually removed from SVN as well, Yes. > and does SVN behave > cleanly that way? Sort of. The import script used to barf on the svn log output for removed revs, I fixed that a few days ago. > If not, is there a possibility that some batch process will > just fill them back in some day when nobody's thinking about it? No way. SVN simply will not give you the data.
still happening :(
Lowering priority on high priority bugs that have a low severity
