Last modified: 2012-04-12 13:54:14 UTC
Created attachment 8532 [details] patch to swap double and single quotes in /includes/OutputPage.php There is an unescaped \n because of single quotes on line 1958 in /includes/OutputPage.php. It is shown when you lock the database with $wgReadonly (in LocalSettings.php) and then visit the preferences page - Special:Preferences. This is what was changed because of bug 19226: r1=61054&r2=61055">http://svn.wikimedia.org/viewvc/mediawiki/tags/REL1_16_0beta1/phase3/includes/OutputPage.php?r1=61054&r2=61055& bug 19226: https://bugzilla.wikimedia.org/show_bug.cgi?id=19226 To fix it '<div class="mw-readonly-error">\n$1</div>' should be "<div class='mw-readonly-error'>\n$1</div>" OutputPage.php is different in MediaWiki version 1.17.0beta1 and when I installed it the bug wasn't there. There is a possible solution as patch. Cheers.
The link to the diff should be r1=61054&r2=61055">http://svn.wikimedia.org/viewvc/mediawiki/tags/REL1_16_0beta1/phase3/includes/OutputPage.php?r1=61054&r2=61055& Sorry.
What is your patch against (you're linking to 1.16.0beta1 - thats a fairly old version, patches should be against the latest version [trunk]). Additionally the issue does not appear to be present on current trunk.
The patch is for 1.16.5, the bug was introduced in 1.16.0beta1. I will mark this as resolved.
