Last modified: 2011-05-17 08:32:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30972, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28972 - Timed text doesn't support InstantCommons
Timed text doesn't support InstantCommons
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Timed text (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-14 13:32 UTC by Derk-Jan Hartman
Modified: 2011-05-17 08:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2011-05-14 13:32:18 UTC
FF3.6/Safari 4 <video> Mac OSX Snow Leopard.

I tried watch TT language tracks on my local host and I get http://localhost/wiki/api.php?action=parse&page=Wikimediacommons%3ATimedText%3AFolgers.ogv.de.srt&format=json
Comment 1 Michael Dale 2011-05-14 17:19:27 UTC
hmm it "should work" .. the prototype box for example loads remote subtitles for the "shared" repository video files:
http://prototype.wikimedia.org/timedmedia/Main_Page

And its working for me locally. Are you running TimedMediaHandler locally? or using the mwEmbed script in some way?
Comment 2 Derk-Jan Hartman 2011-05-15 21:03:25 UTC
i was using instantcommons  + timedmediahandler + MwEmbedSupport

There are rather big differences between ForeignDb and ForeignAPI. Might be that that is where the issue lies.
Comment 3 Michael Dale 2011-05-15 23:02:27 UTC
(In reply to comment #2)
> i was using instantcommons  + timedmediahandler + MwEmbedSupport
> 
> There are rather big differences between ForeignDb and ForeignAPI. Might be
> that that is where the issue lies.

It should load the files from the remote host ( not local host ). On my box it outputs the following track tags: 

<track kind="subtitles" 
data-mwtitle="TimedText:Folgers.ogv.de.srt" 
data-mwprovider="commons" type="text/x-srt" 
src="http://commons.wikimedia.org/wiki/TimedText:Folgers.ogv.de.srt?action=raw&amp;ctype=text%2Fx-srt"
srclang="de" 
label="Deutsch (de) subtitles">
</track>

And then the player issues an api request to load the subtitles cross domain, so it grabs: http://commons.wikimedia.org/w/api.php?callback=jsonp1305500357102&action=parse&page=TimedText%3AFolgers.ogv.de.srt&format=json

What is your video tag output look like?
Comment 4 Derk-Jan Hartman 2011-05-16 19:48:00 UTC
<video id="mwe_player_0" style="width:352px;height:264px" poster="/wiki/images/thumb/9/94/Folgers.ogv/mid-Folgers.ogv.jpg" alt="Folgers.ogv" controls="true" class="kskin" data-durationhint="60" data-startoffset="0" data-mwtitle="Folgers.ogv" data-mwprovider="wikimediacommons"><source src="http://upload.wikimedia.org/wikipedia/commons/9/94/Folgers.ogv" title="Original ogg, 352 × 264 (637kbps)" data-shorttitle="Ogg source" data-width="352" data-height="264" data-bandwidth="636645" data-framerate="29.97002997003" /><track kind="subtitles" data-mwtitle="Wikimediacommons:TimedText:Folgers.ogv.de.srt" data-mwprovider="wikimediacommons" type="text/x-srt" src="http://localhost/wiki/index.php/Wikimediacommons:TimedText:Folgers.ogv.de.srt?action=raw&amp;ctype=text%2Fx-srt" srclang="de" label="Deutsch (de) subtitles" /><track kind="subtitles" data-mwtitle="Wikimediacommons:TimedText:Folgers.ogv.en.srt" data-mwprovider="wikimediacommons" type="text/x-srt" src="http://localhost/wiki/index.php/Wikimediacommons:TimedText:Folgers.ogv.en.srt?action=raw&amp;ctype=text%2Fx-srt" srclang="en" label="English (en) subtitles" /><track kind="subtitles" data-mwtitle="Wikimediacommons:TimedText:Folgers.ogv.fr.srt" data-mwprovider="wikimediacommons" type="text/x-srt" src="http://localhost/wiki/index.php/Wikimediacommons:TimedText:Folgers.ogv.fr.srt?action=raw&amp;ctype=text%2Fx-srt" srclang="fr" label="Français (fr) subtitles" /><track kind="subtitles" data-mwtitle="Wikimediacommons:TimedText:Folgers.ogv.sv.srt" data-mwprovider="wikimediacommons" type="text/x-srt" src="http://localhost/wiki/index.php/Wikimediacommons:TimedText:Folgers.ogv.sv.srt?action=raw&amp;ctype=text%2Fx-srt" srclang="sv" label="Svenska (sv) subtitles" />Sorry, your browser either has JavaScript disabled or does not have any supported player.<br /> You can <a href="h">download the clip</a> or <a href="http://www.mediawiki.org/wiki/Extension:OggHandler/Client_download">download a player</a> to play the clip in your browser.</video>
Comment 5 Derk-Jan Hartman 2011-05-16 20:13:01 UTC
Got it. The reponame of InstantCommons is wikimediacommons, and not 'shared' as the code assumes. 'shared' is the name of the ForeignDb repository.
Comment 6 Derk-Jan Hartman 2011-05-16 20:42:29 UTC
Fixed in r88265
Comment 7 Michael Dale 2011-05-17 08:29:59 UTC
Looks like its working. 

Its now also tested with $wgUseInstantCommons = true;
Comment 8 Derk-Jan Hartman 2011-05-17 08:32:17 UTC
This might also be something to wrap in a central spot btw, because now it's distributed over 2 code points, so anytime something changes, you have to go on a wild goose chase.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links