Last modified: 2011-05-17 08:21:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30973, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28973 - TimedMediaHandler Audio player unusable due to 0px fixed height
TimedMediaHandler Audio player unusable due to 0px fixed height
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Video player (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-14 13:38 UTC by Derk-Jan Hartman
Modified: 2011-05-17 08:21 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
screenshot of the problem (148.73 KB, image/png)
2011-05-14 13:38 UTC, Derk-Jan Hartman 		Details
screenshot of FF4 dimensions (128.16 KB, image/png)
2011-05-16 20:45 UTC, Derk-Jan Hartman 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2011-05-14 13:38:04 UTC 

    


      




        
          Comment 1
        

        
          Derk-Jan Hartman

        

        
        

        
          2011-05-14 13:38:41 UTC
        
      





Created attachment 8534 [details]
screenshot of the problem

    


      




        
          Comment 2
        

        
          Michael Dale

        

        
        

        
          2011-05-15 22:56:20 UTC
        
      





This is fixed in r88192

    


      




        
          Comment 3
        

        
          Derk-Jan Hartman

        

        
        

        
          2011-05-16 20:43:58 UTC
        
      





Only the height is not 20px, its 23px isn't it ?

    


      




        
          Comment 4
        

        
          Derk-Jan Hartman

        

        
        

        
          2011-05-16 20:45:56 UTC
        
      





Created attachment 8540 [details]
screenshot of FF4 dimensions

    


      




        
          Comment 5
        

        
          Michael Dale

        

        
        

        
          2011-05-17 08:21:21 UTC
        
      





Your right. I was going back and forth on the best size here, since it should really be controlled by player and not be in two places ( oggHandler output and the control builder inside EmbedPlayer ) 

If for example a site switched the skin for the player it may not fit well in 23 pixels so may want a different default. This has to be thought about and improved to share some configuration across php and the player. Also the wiki embed code can change the size too. 

but for now, updated to 23px r88288 ;)

    



  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.
            

          		
        
 
      

  
        





        




  
  First
  Last
  Prev
  Next
    
  This bug is not in your last
    search results.







			

			
		
		
		
		
		
		
			

				
				
				
				
				

					
Navigation

					

						
					

				

				
				
				
				
				

					
Links