Last modified: 2011-05-16 23:22:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31011, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29011 - Special:lockdb should not hard code english but use a message for the by line in the lock file.
Special:lockdb should not hard code english but use a message for the by line...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.20.x
All All
: Unprioritized minor (vote)
: ---
Assigned To: Siebrand Mazeland
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-16 14:59 UTC by The Evil IP address
Modified: 2011-05-16 23:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description The Evil IP address 2011-05-16 14:59:26 UTC
Currently, the content that's written to $wgReadOnlyFile (in http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialLockdb.php?view=markup&pathrev=88189) is mixed, something in English and something in the wiki language. The reason may be any language and can't be controlled by the MediaWiki software, but the following text is partially in English, but the date is in the wiki language, which can give crazy results. Please either completely localize the file or make it all in English. Thanks.
Comment 1 Niklas Laxström 2011-05-16 16:15:00 UTC
What does this have to do with MediaWiki?
Comment 2 Bawolff (Brian Wolff) 2011-05-16 22:58:48 UTC
I think he's referring to:

125 	 fwrite( $fp, "\n<p>(by " . $wgUser->getName() . " at " .
126 	$wgContLang->timeanddate( wfTimestampNow() ) . ")</p>\n" );

Which writes who locked the db to the lock file, after its written the reason for the locking of the db.

Which should probably be some message instead, as otherwise you could have the "by" mixing with non-english text. Probably would look really wrong in RTL lang.
Comment 3 Siebrand Mazeland 2011-05-16 23:22:19 UTC
Fixed in 88278. Who locked the database and when will be displayed in the content language, as reason, locker and timestamp are saved in $wgReadOnlyFile.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links