Last modified: 2012-05-14 10:15:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31013, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29013 - ResourceLoader::register() called for page views
ResourceLoader::register() called for page views
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-16 15:57 UTC by Roan Kattouw
Modified: 2012-05-14 10:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2011-05-16 15:57:32 UTC 
It seems register() is called in cases where it's not needed. Domas showed me a profile of Special:Blankpage where register() is called 106 times, that's excessive.
Comment 1 Mark A. Hershberger 2011-05-19 16:34:37 UTC 
I'm going to profile the unit tests, fwiw, in the process of getting them to run faster.  MOAR PROFILING!!!
Comment 2 Roan Kattouw 2011-11-19 16:30:04 UTC 
I made register() non-recursive in r103682, that reduces the number of calls and hopefully makes things faster.
Comment 3 Roan Kattouw 2011-11-19 16:44:03 UTC 
(In reply to comment #2)
> I made register() non-recursive in r103682, that reduces the number of calls
> and hopefully makes things faster.
That did indeed make register() take 8x less time on the live site.

Since we can't actually avoid initializing RL on page views, I'm gonna close this bug.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links