Last modified: 2014-11-17 10:35:44 UTC
The following line has a linked revision id (revision 2): <div id="chapter2">Foobar</div>
Bugmeister is the new Bugzilla maintainer and default assignee.
This appears to corrupt SVN ViewVC links that use &r1= and &r2= in them. The original problem shouldn't be very difficult to fix with word boundaries (\b). Not sure how you fix <r1=foo&r2=bar">http://example.com/?r1=foo&r2=bar>, though.
Created attachment 8858 [details] Untested patch to improve SVN revision matching in Bugzilla comments This is an untested patch that improves the custom "Wikimedia" extension used by Bugzilla to stop matching "rXXX" in certain cases and to match "rXXX#cYYY" in other cases. The following test cases were used: r1 This was fixed in r2. I laid out the reasons this sucks in r3#c0. You can read why you suck at r4#code-comments. r5=0&r6=0">http://example.com/?r5=0&r6=0 <div id="chapter2">hello!</div>
The proposed patch would also resolve bug 28765.
MZMcBride's patch looks sane and good, no problems that I can see and it would fix both this bug and bug 28765.
*** Bug 30161 has been marked as a duplicate of this bug. ***
Created attachment 8865 [details] Tested patch This is a cleaned up and tested version of MZ's patch. I want to take advantage of Bz's testing infrastructure, so I'm not committing this yet.
The whitespace changes were annoying, yes, but the whitespace seemed particularly stupid throughout. I felt justified.
still not fixed, but unless I really get into Bugzilla hacking, I'm not doing it.
Putting the patch into Gerrit is highly welcome: https://git.wikimedia.org/blob/wikimedia%2Fbugzilla%2Fmodifications.git/HEAD/extensions%2FWikimedia%2FExtension.pm
*** Bug 28765 has been marked as a duplicate of this bug. ***
