Last modified: 2011-07-31 19:01:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31043, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29043 - The 'Contents box' in the "Printable version" rendering is stupid
The 'Contents box' in the "Printable version" rendering is stupid
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 30155 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-18 22:44 UTC by technoidog
Modified: 2011-07-31 19:01 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to add/remove css class tochidden in toggleToc (1.22 KB, patch)
2011-06-01 07:09 UTC, Fomafix
Details

Description technoidog 2011-05-18 22:44:49 UTC
The purpose of the 'Contents box' is to act as an index, and provide a document relevant URI shortcut collect. It's presence is sensible in an interactive environment. However, its presence does not make any sense in the printed context. The presence of the 'Contents box', and all of included header data, is a massive waste of paper space, and mandates a massive correlated waste of time to fix, in order to remove, before printing. Thus, the 'Contents box' should be removed during the production of the "Printable version"s of Wikipedia documents. Otherwise, an option should be available to produce 'Contents box' free Wikipedia documents in the "Print/export" section.
Comment 1 Mark A. Hershberger 2011-05-21 00:03:10 UTC
see r88502, but I'm interested in hearing other opinions, too.
Comment 2 Mark A. Hershberger 2011-05-30 16:21:03 UTC
Going to revert this fix per comment on r88502:

  I think the table of contents on paper is not stupid, it is often useful.

  If you don't want to print the table of contents then klick on [hide] and the
  whole box with the table of contents gets hidden in the print version. 

So I'm thinking this would be better to fix with a gadget.
Comment 3 Fomafix 2011-05-31 07:39:36 UTC
(In reply to comment #2)
> So I'm thinking this would be better to fix with a gadget.

You don't need a gadget. This feature already exists. See bug 482. But this feature doesn't work anymore since porting to resource loader in r78941 because the class tochidden is not set by JavaScript anymore. tochidden is still in commonPrint.css: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/commonPrint.css?view=annotate#l120

Please revert r88502 and repair tochidden in r78941.
Comment 4 Fomafix 2011-06-01 07:09:11 UTC
Created attachment 8607 [details]
Patch to add/remove css class tochidden in toggleToc

Patch to reactivate the css class 'tochidden' for bug 482 as a follow-up to r78941.
Comment 5 Mark A. Hershberger 2011-06-02 16:41:41 UTC
r89349
Comment 6 Dan Collins 2011-07-31 18:34:45 UTC
*** Bug 30155 has been marked as a duplicate of this bug. ***
Comment 7 technoidog 2011-07-31 18:54:30 UTC
While clicking the 'Content' section [hide] button colapses the 'Content' section section in the interactive version, it does not carry this desire thru after selection of "Print/export -> Printable version". The content is included in the 'Printable version', as always. So, this 'feature' is still, only half working.
Comment 8 Dan Collins 2011-07-31 18:56:42 UTC
*** Bug 30155 has been marked as a duplicate of this bug. ***
Comment 9 Dan Collins 2011-07-31 19:01:54 UTC
This was fixed, it just doesn't appear to be live on wikimedia foundation sites yet. It works fine on my testwiki. Closing FIXED again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links