Last modified: 2011-05-23 22:45:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31096, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29096 - Height of dialog view for video with long title.
Height of dialog view for video with long title.
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Video player (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-22 20:45 UTC by Derk-Jan Hartman
Modified: 2011-05-23 22:45 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
screenshot of incorrect dialog content dimensions (80.28 KB, image/png)
2011-05-22 20:45 UTC, Derk-Jan Hartman 		Details
screenshot with no specific width and height specified (71.33 KB, image/png)
2011-05-22 20:45 UTC, Derk-Jan Hartman 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2011-05-22 20:45:05 UTC 
Created attachment 8566 [details]
screenshot of incorrect dialog content dimensions

This is a small visual issue. Please see attachment.

This is caused by the long title. The long title causes the height of the toolbar to become larger, thus the hardcoded value of +45 in mw.PopUpThumbVideo.js is no longer correct.

I'm not sure exactly why a specific set of dimensions is given in this case. Would it not be better to leave the defaults of auto width and height ?
Comment 1 Derk-Jan Hartman 2011-05-22 20:45:30 UTC 
Created attachment 8567 [details]
screenshot with no specific width and height specified
Comment 2 Michael Dale 2011-05-23 22:45:22 UTC 
set width and height to auto in r88698
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links