Last modified: 2011-07-07 20:18:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31103, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29103 - Significant speedup for doQuotes
Significant speedup for doQuotes
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.20.x
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-23 01:25 UTC by William Demchick
Modified: 2011-07-07 20:18 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
A new version of doQuotes (9.95 KB, patch)
2011-05-23 01:25 UTC, William Demchick 		Details
Add an attachment (proposed patch, testcase, etc.)

Description William Demchick 2011-05-23 01:25:58 UTC 
Created attachment 8569 [details]
A new version of doQuotes

Attached is a patch that alters doQuotes, a member of Parser.

Initial experimentation seems to show that the altered doQuotes runs in about two-thirds the time of the original version.

The main alteration is that quote groups in $arr are encoded using integers, not strings.  This both offers a speedup, and (in my opinion) makes the code more readable.

There are a few other alterations of minor importance.
Comment 1 William Demchick 2011-05-23 09:03:59 UTC 
Given bug 29111, this seems a bit more important.
Comment 2 Brion Vibber 2011-05-25 21:15:14 UTC 
Can you show your benchmarks? I wouldn't expect doQuotes to take up a large amount of parsing time at all; a speedup here may not be worth changing fragile code.
Comment 3 William Demchick 2011-05-25 21:44:26 UTC 
I took a look again at the numbers, and the old doQuotes seems to be running for less than a ms on a several second page request.  So, it probably isn't worth it.
Comment 4 Jarry1250 2011-07-05 18:03:44 UTC 
Is this WONTFIX then?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links