Last modified: 2011-06-01 00:14:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31107, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29107 - WikiEditor doesn't work in debug mode
WikiEditor doesn't work in debug mode
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-23 07:21 UTC by Michael M.
Modified: 2011-06-01 00:14 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2011-05-23 07:21:58 UTC
I report this in the RessourceLoader component since I think that this issue is not WikiEditor-specific.
To reproduce open any page for editing in debug mode (action=edit&debug=true). Though WikiEditor is enabled and works in normal mode, it does not appear in debug mode.

I think that this is what happens:
jquery.wikiEditor.toolbar.i18n has no scripts (only messages), so registry[...].script is set to an empty array, so the execute-method never sets the state to "ready" as expected. The dependend modules aren't executed, the toolbar doesn't appear. In production mode the script is an empty function, so the state is set properly and the bug doesn't appear.
Comment 1 Krinkle 2011-05-23 22:11:00 UTC
I believe this has been fixed in trunk (1.19-alpha).

Which version did you reproduce the bug on ? (if not trunk, could try to reproduce on trunk by checking out or by trying on http://translatewiki.net/ )
Comment 2 Brion Vibber 2011-05-24 00:32:35 UTC
I can confirm bug on trunk in r88704.
Comment 3 Brion Vibber 2011-05-24 00:44:07 UTC
I concur with Michael's diagnosis; r88706 seems to fix it up for me by marking the module as loaded properly in the case that there's an array of zero scripts.

Please test w/ other modules to confirm!
Comment 4 Brion Vibber 2011-06-01 00:14:50 UTC
qunit test case added in r89243.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links