Last modified: 2011-06-06 17:48:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31156, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29156 - Hide ArticleFeedback tool from print view
Hide ArticleFeedback tool from print view
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedback (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Trevor Parscal
https://secure.wikimedia.org/wikipedi...
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-26 18:57 UTC by Dario Taraborelli
Modified: 2011-06-06 17:48 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Roan Kattouw 2011-05-26 18:58:45 UTC
This should be trivial with something like @media print { .blah { display: none; } }
Comment 3 Helder 2011-05-30 21:15:13 UTC
[Mid-air collision detected!]

(In reply to comment #1)
> This should be trivial with something like @media print { .blah { display:
> none; } }

Or someone could add a line similar to that of r88151 to avoid the redirects. Specifically, the following should be sufficient:

 && mw.util.getParamValue( 'printable' ) != 'yes'
Comment 4 Derk-Jan Hartman 2011-05-30 21:41:42 UTC
(In reply to comment #3)
> [Mid-air collision detected!]
> 
> (In reply to comment #1)
> > This should be trivial with something like @media print { .blah { display:
> > none; } }
> 
> Or someone could add a line similar to that of r88151 to avoid the redirects.
> Specifically, the following should be sufficient:
> 
>  && mw.util.getParamValue( 'printable' ) != 'yes'

no, that won't work for bookview and users who don't actually have to use the printable link (that would be anybody not using IE6) in order to get the printview when printing.
Comment 5 Helder 2011-05-30 22:09:21 UTC
(In reply to comment #4)
> no, that won't work for bookview and users who don't actually have to use the
> printable link (that would be anybody not using IE6) in order to get the
> printview when printing.

I'm not sure about what you mean by "bookview". Could you clarify?
Comment 6 Derk-Jan Hartman 2011-05-30 22:30:53 UTC
PDF and pediapress parsing. Though since this is a JS tool, it probably won't matter for that tool. Still, print view does not require you to click "Printable version" that's just for IE6 users.
Comment 7 Helder 2011-05-30 22:36:51 UTC
(In reply to comment #6)
> PDF and pediapress parsing. Though since this is a JS tool, it probably won't
> matter for that tool.

Ah, ok.

> Still, print view does not require you to click
> "Printable version" that's just for IE6 users.

o.o

Good to know!
Comment 8 Erik Moeller 2011-05-31 02:20:23 UTC
Should be fixed in r89198, pending code review.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links