Last modified: 2013-03-19 19:44:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31200, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29200 - Creation of new thread fails silently if no content is entered, but this should be possible. Solution: add automatically thread title as HTML comment(!) to new page, or throw error message
Creation of new thread fails silently if no content is entered, but this shou...
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Extensi...
:
Depends on:
Blocks: 29390
  Show dependency treegraph
 
Reported: 2011-05-29 15:50 UTC by T. Gries
Modified: 2013-03-19 19:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2011-05-29 15:50:54 UTC
When adding a new thread, for example as a placeholder to motivate new comments to a subject, or to ask a short question, the current Lqt implementation fails to create the new thread

- if only the discussion title ("Subject" line when clicking "Start a new discussion") is given ; and
- if no content is entered in to text input field for the content

observed in Liquid Threads (Version 2.0-alpha) 	(r89075)

As far as I understand, the technical reason is that the underlying sub page creation for the subject fails - when no content is present.

However, in the framework of creation of a better user interface of Wikipedia and MediaWiki Talk pages, this should be possible, though.

I suggest to create in this case automatically page with a placeholder content, namely the given Lqt thread title subject as HTML content in the sub page body.
Thus the page looks empty, but has (relevant-to-thread) dummy content.
Comment 1 T. Gries 2011-05-30 23:37:03 UTC
(In reply to comment #0)
> When adding a new thread, for example as a placeholder to motivate new comments
> to a subject, or to ask a short question, the current Lqt implementation fails
> to create the new thread
> 
> - if only the discussion title ("Subject" line when clicking "Start a new
> discussion") is given ; and
> - if no content is entered in to text input field for the content
> 
> observed in Liquid Threads (Version 2.0-alpha)     (r89075)
> 

Show at least a warning to the user that they forgot to enter any text in the body and therefore the new thread will not be created.
Comment 2 Andrew Garrett 2011-05-31 07:25:41 UTC
I'm not going to prioritise this bug for fixing before the backend rewrite is done. It will probably be fixed by that.
Comment 3 T. Gries 2011-05-31 07:40:22 UTC
But is is very easy to fix in the present version using my ad-hoc solution. Please.
Comment 4 Andrew Garrett 2011-05-31 14:10:28 UTC
(In reply to comment #3)
> But is is very easy to fix in the present version using my ad-hoc solution.
> Please.

Not really. LiquidThreads' edit form is, at present, too tightly coupled to the page editing code. It would require hackery or substantial refactoring. I'm happy to look at patches, but given the (lack of) use case, I'm finding it hard to make an exception to my general strategy of focussing on the updated backend.
Comment 5 T. Gries 2011-06-13 12:58:33 UTC
fixed in r89958
Comment 6 Brion Vibber 2011-06-13 23:30:49 UTC
r89958 looks like a workaround for failure to handle error conditions in the JavaScript code.

The error info from the dieUsage appears to perfectly correctly make it back to the 'doneCallback' function in 'handleAJAXSave' (via the actual call in liquidThreads.doNewThread).

However, doneCallback tries to handle error conditions by submitting the same form as non-Ajax in the hopes that that code path will show an error as well, which apparently isn't ending up having the expected results.

It should instead probably show the error message directly.....? Does this need more general or more specific handling for particular kinds of errors that we can't report back cleanly through this interface?
Comment 7 T. Gries 2011-09-23 18:04:27 UTC
reopened ! because today's reversion of r89958 bring this bug back again. Sorry, friends.

Attention Andrew: please fix this problem "Creation of new thread fails silently if no content is entered".
Comment 8 sheac 2012-05-04 16:49:50 UTC
This bug has not been touched in at least six months. With this in mind, I've been asked by the bugmeister to bump this bug's priority down for "High". Concerns can be addressed to mah@everybody.org.
Comment 9 Valerie Juarez 2013-03-19 19:44:32 UTC
When attempting to create a new thread on https://test2.wikipedia.org/wiki/Talk:Xpd with with text in the subject but none in the body of the post, I got a message saying "You cannot post a blank message". I also tried to reply with a blank post and got the same message.


Closing as WORKSFORME.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links