Last modified: 2012-09-27 01:11:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31204, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29204 - tooltipAndAccesskeyAttribs called incorrectly
tooltipAndAccesskeyAttribs called incorrectly
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-29 20:21 UTC by Aaron Schulz
Modified: 2012-09-27 01:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aaron Schulz 2011-05-29 20:21:54 UTC
tooltipAndAccesskeyAttribs is called on line 219 of Vector.php :

<!-- logo -->
					<div id="p-logo"><a style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo Linker::tooltipAndAccesskeyAttribs( 'p-logo' ) ?>></a></div>
				<!-- /logo -->

It just prints "Array" since that's what the result is, an array. It should expand them.
Comment 1 Brion Vibber 2011-05-31 19:08:34 UTC
Regression in r87584: swapped out Linker::tooltipAndAccesskey() calls which were correct for Linker::tooltipAndAccesskeyAttribs() calls which are not correct.

It looks like somebody also removed the original function, so it can't just be easily reverted... probably reedy. :) Assigning.
Comment 2 Krinkle 2011-05-31 19:10:11 UTC
See also:

* r87584
* r87963
Comment 3 Sam Reed (reedy) 2011-05-31 20:23:45 UTC
r89224 also
Comment 4 Brion Vibber 2011-05-31 20:39:01 UTC
Note that the fix above is to inline the original Linker::tooltipAndAccessKey() function (wrapping a Linker::tooltipAndAccessKeyAttribs() call in Xml::expandAttributes()) in that one place where it actually gets used directly as a string.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links