Last modified: 2011-06-12 03:41:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31275, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29275 - ArticleFeedback API: exception thrown if no ratings
ArticleFeedback API: exception thrown if no ratings
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedback (Other open bugs)
unspecified
All All
: Unprioritized minor (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-05 00:38 UTC by Gurch
Modified: 2011-06-12 03:41 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gurch 2011-06-05 00:38:07 UTC
In ApiQueryArticlceFeedback, passing a page ID for which article feedback is not enabled produces an error.


http://en.wikipedia.org/w/api.php?action=query&list=articlefeedback&afpageid=12345

  <error code="internal_api_error_MWException" info="Exception Caught: Internal error in ApiResult::setIndexedTagName: Bad parameter" xml:space="preserve">

#0 /usr/local/apache/common-local/php-1.17/includes/api/ApiBase.php(1111): wfDebugDieBacktrace('Internal error ...')
#1 /usr/local/apache/common-local/php-1.17/includes/api/ApiResult.php(202): ApiBase::dieDebug('ApiResult::setI...', 'Bad parameter')
#2 /usr/local/apache/common-local/php-1.17/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php(114): ApiResult->setIndexedTagName(NULL, 'r')
#3 /usr/local/apache/common-local/php-1.17/includes/api/ApiQuery.php(262): ApiQueryArticleFeedback->execute()
#4 /usr/local/apache/common-local/php-1.17/includes/api/ApiMain.php(657): ApiQuery->execute()
#5 /usr/local/apache/common-local/php-1.17/includes/api/ApiMain.php(339): ApiMain->executeAction()
#6 /usr/local/apache/common-local/php-1.17/includes/api/ApiMain.php(323): ApiMain->executeActionWithErrorHandling()
#7 /usr/local/apache/common-local/php-1.17/api.php(115): ApiMain->execute()
#8 /usr/local/apache/common-local/live-1.5/api.php(3): require('/usr/local/apac...')
#9 {main}

</error>


This should be handled and a more user-friendly error message provided.
Comment 1 Roan Kattouw 2011-06-12 03:41:05 UTC
Fixed by the reporter in r89893. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links