Last modified: 2011-06-09 04:53:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31295, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29295 - Style tags getting filtered out on collabwiki (inside rawhtml)
Style tags getting filtered out on collabwiki (inside rawhtml)
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-07 01:35 UTC by James Alexander
Modified: 2011-06-09 04:53 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Alexander 2011-06-07 01:35:33 UTC
$wgRawHtml was enabled on CollabWiki yesterday with bug 29269 but for some reason we are not getting the expected results. It appears that css within <style> tags is getting filtered out of the final source while the rest of the html (including scripts) is being processed. This is not the result gotten on FoundationWiki which also has $wgRawHtml enabled with the same test pages (copied over to Collab).

Examples for those with access:
http://collab.wikimedia.org/wiki/Template:2010/Donate-appeal3
http://wikimediafoundation.org/wiki/Template:2010/Donate-appeal3

This appears to have some history given the comment on mediawiki.org from 2009 ( http://www.mediawiki.org/wiki/Manual_talk:$wgRawHtml#.3Cstyle.3E_tags_filtered_out) but I haven't found any extensive discussion about it.
Comment 1 James Alexander 2011-06-07 02:31:15 UTC
I haven't found any discussion about it from back when it was set yet but we may have found the culprit in $wgUseTidy. Evidently there were problems with output on FoundationWiki and that was the culprit. It is still set as false for FoundationWiki at http://noc.wikimedia.org/conf/CommonSettings.php.txt .
Comment 2 Arthur Richards 2011-06-07 17:03:42 UTC
Set $wgUseTidy = false for collabwiki.
Comment 3 Bawolff (Brian Wolff) 2011-06-09 04:26:28 UTC
As an aside, putting style tags inside the <body> is in violation of the html spec (well maybe not html5, but previous html specs), which is probably why tidy is messing with it.
Comment 4 James Alexander 2011-06-09 04:53:38 UTC
aye, I think that's exactly why. Sadly really the best way to do it on rawhtml wiki's right now I think (rather then large amounts of common.css styling for individual pages)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links