Last modified: 2014-07-08 18:42:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31300, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29300 - [tools/code-utils] check-vars.php: Add optional warning to passing $this by reference
[tools/code-utils] check-vars.php: Add optional warning to passing $this by r...
Status: NEW
Product: Utilities
Classification: Unclassified
code-utils (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-07 17:55 UTC by Chad H.
Modified: 2014-07-08 18:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chad H. 2011-06-07 17:55:48 UTC 
Passing objects by reference isn't necessary in PHP5. I imagine it would be hard to check for any var that is an object to warn for pass-by-ref, but checking for the special case of $this should be easier.

Make it optional, because I know there's a lot of violators of the rule (and it's not strictly harmful)
Comment 1 Platonides 2011-06-07 20:09:19 UTC 
So, you want a warning whenever the tokens & $this appear?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links