Last modified: 2011-06-10 17:12:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31312, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29312 - Central Notices shouldn't CSS class themselves as sitenotices
Central Notices shouldn't CSS class themselves as sitenotices
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-07 23:57 UTC by p858snake
Modified: 2011-06-10 17:12 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description p858snake 2011-06-07 23:57:43 UTC
Messages sent via CN shouldn't give them selves CSS classes that appear as site notices.
Comment 1 Ryan Kaldari 2011-06-08 00:47:42 UTC
I'm not sure I understand this bug. In the old days both centralNotice banners and local siteNotice banners were put into the siteNotice div without any differentiation. Last year we changed this so that centralNotice banners are in siteNotice>centralNotice and local siteNotice banners are in siteNotice>localNotice. Thus you can select all the notices together as a unit, or you can select them indivudually. What else is needed?
Comment 2 Ryan Kaldari 2011-06-10 00:42:24 UTC
Without a better explanation of the logic behind this change, I'm inclined to mark as WONTFIX.
Comment 3 p858snake 2011-06-10 01:21:16 UTC
<!-- sitenotice -->
	<div id="siteNotice"><!-- centralNotice loads here --></div>
<!-- /sitenotice -->


it would make it easier if they wern't in the sitenotice div so people that don't want the CN spam to be able to hide it without effecting sitenotices.
Comment 4 Ryan Kaldari 2011-06-10 17:12:42 UTC
To hide centralNotices, set:
#centralNotice { display: none; }

To hide local siteNotices, set:
#localNotice { display: none; }

To hide both, set:
#siteNotice { display: none; }

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links