Last modified: 2011-06-09 18:10:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31322, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29322 - jquery.wikiEditor.js contains some iframe-specific code
jquery.wikiEditor.js contains some iframe-specific code
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-09 00:16 UTC by Brion Vibber
Modified: 2011-06-09 18:10 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2011-06-09 00:16:36 UTC 
jquery.wikiEditor.js contains what appears to be some iframe-specific code such as a 'keydown' event handler that deals with ctrl+z, ctrl+y, ctrl+v, and tab.

This calls into context.fn.* functions which only appear in jquery.wikiEditor.iframe.js, such as updateHistory() and purgeOffsets(). It also doesn't appear to actually get called at all in the regular textarea mode, which explains why we don't see errors from it. ;)

Probably just needs moving over to the extension file.
Comment 1 Brion Vibber 2011-06-09 18:10:21 UTC 
Moved it over in r89778, seems fine.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links