Last modified: 2012-04-12 13:55:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31325, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29325 - Setting $wgStrictFileExtensions to false gives incorrect warning
Setting $wgStrictFileExtensions to false gives incorrect warning
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-09 12:44 UTC by mediawiki
Modified: 2012-04-12 13:55 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description mediawiki 2011-06-09 12:44:54 UTC 
... The warning in question is for example 

(example)
".txt" is an unwanted file type. Preferred file types are $2.
(/example)

Note the $2.
Comment 1 Brion Vibber 2011-06-09 17:59:27 UTC 
Confirmed still present in trunk.

Looks like the warning message gets set in UploadBase::checkWarnings(), but parameters for those messages don't get added until output time in SpecialUpload::showUploadWarning.

That function has some special cases for specific warning messages to customize the output; the one to watch for is 'filetype-unwanted-type'.

The similar 'filetype-banned-type' message is processed separately in SpecialUpload::processVerificationError, so may need some common list building.
Comment 2 Matěj Grabovský 2011-06-18 21:27:56 UTC 
Fixed in r90369.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links