Last modified: 2014-04-07 14:07:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31329, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29329 - iframe-specific assumptions in other WikiEditor modules
iframe-specific assumptions in other WikiEditor modules
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-10 00:26 UTC by Brion Vibber
Modified: 2014-04-07 14:07 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-06-10 00:26:30 UTC
Found while testing out stuff w/ bug 29328... This iframe-specific code gets called from the WikiEditor toolbar module:

  if ( context.$iframe !== undefined ) {
    context.$iframe[0].contentWindow.focus();
  }

The actual text insertion is abstracted via jquery.textSelection (but not perfectly -- see bug 29328!) but the focus isn't. Probably needs to be made into a function on the WikiEditor context object, so the iframe extension can override it.

There are probably others...

* dialogs: explicit code to trigger iframe initialization... seems like this should be pushed back a level so we just tell WikiEditor to load & init the extension if not already loaded?

* dialogs.config: another focus() hack, and a special keypress binding with the search/replace dialog, which probably just needs to be able to grab an appropriate element to bind on which could then be done generically

* templateEditor pokes some data stuff on the $iframe, but that may be ok as it's totally dependent on the iframe thing anyway.
Comment 1 Andre Klapper 2014-04-07 14:07:27 UTC
The unmaintained beta iframe mode was removed from WikiEditor recently in WikiEditor: https://gerrit.wikimedia.org/r/#/c/123649/

Hence closing as WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links