Last modified: 2013-09-04 10:36:30 UTC
Created attachment 8634 [details] Patch Giving an array for $wgExtensionCredits['descriptionmsg'] (i.e. message key plus parameters) breaks Special:Version (giving an Internal Error). The array is passed to wfEmptyMsg which expects a message key. MediaWiki 1.17.0rc1 (r89818) (Works on 1.16, did not check on 1.17+.)
Why would you supply parameters to a static message? What parameter would be available at LocalSettings.php time that would be suitable?
I do not set this parameter at LocalSettings.php time, but in a hook handler. The parameter is a pagename that can be set through a variable in LocalSettings to configure the extension. Setting the variable is done after the require_once for the extension. (The author of Special:Version obviously also thought, that giving a parameterized message should be possible. He explicitly tests if the message is an array or a string and processes it accordingly.)
This was fixed back in r78996 (1.18) by Nikerabbit. I agree that it seems weird to have a parameter for that, but all our docs say that you can. I have no idea if this is the type of thing we'd want to backport to 1.17 (Since its a regression) or if its too late for that.
probably too late for 1.17.0 ... maybe we should make a list of patches for 1.17.1, though.
I'm removing the keyword need-review, since the issue is already fixed in trunk, so the patch doesn't really need to be reviewed (hope that's right).
I'm going to close this fixed (since it was fixed in 1.18). There's really not much to do here since 1.17 is already long released.
