Last modified: 2014-04-17 20:03:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31336, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 29336 - Hide MultiUpload files and allow to add next file dynamically (JS)


Summary:	Hide MultiUpload files and allow to add next file dynamically (JS)

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	MultiUpload (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Lee Worden

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-06-10 11:55 UTC by Nux
Modified:	2014-04-17 20:03 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Adds a next file button and also fixes a problem of taking file name from wpDestFile (this happens when you have a link to non-existent file) (4.12 KB, application/octet-stream) 2011-06-10 11:55 UTC, Nux	Details
Adds a next file button and also fixes a problem of taking file name from wpDestFile (this happens when you have a link to non-existent file) (4.44 KB, patch) 2011-06-10 18:59 UTC, Nux	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Nux 2011-06-10 11:55:59 UTC

Created attachment 8635 [details]
Adds a next file button and also fixes a problem of taking file name from wpDestFile (this happens when you have a link to non-existent file)

In current situation the form is only readable when you allow users to upload few files. It's not so usable when you allow users to upload e.g. 20 files and user only want to send one or two it's - the description field is then far below and not visible to the user.

So the solution I believe works best is a next file button and only show fields for one file.

Patch attached.

Comment 1 Nux 2011-06-10 18:59:26 UTC

Created attachment 8636 [details]
Adds a next file button and also fixes a problem of taking file name from wpDestFile (this happens when you have a link to non-existent file)

Patch fixed in accordance to MW Coding Conventions

Comment 2 Sumana Harihareswara 2011-09-30 16:00:40 UTC

Added the "patch" and "need-review" keywords; Mark hopes to get someone to review the patch soon.

Comment 3 Lee Worden 2014-04-10 02:41:43 UTC

The new MultiUpload extension I checked in today includes controls to add and remove files, and allows them to collapse into a small area to reduce clutter.

Comment 4 Andre Klapper 2014-04-10 12:26:13 UTC

Lee: So do you want to close this ticket as RESOLVED FIXED as per comment 3?

Comment 5 Lee Worden 2014-04-10 16:36:46 UTC

Andre: I figured I'd wait to see if there's any negative fallout from the change.  I'll check back in about a week...

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links