Last modified: 2012-03-09 11:27:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31340, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29340 - Group names with html entities in them get double encoded in Special:Userrights
Group names with html entities in them get double encoded in Special:Userrights
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-10 17:11 UTC by Christian Neubauer
Modified: 2012-03-09 11:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christian Neubauer 2011-06-10 17:11:19 UTC 
If you create a group with an HTML entity in it, say A&B, the group name is displayed on Special:Userrights as A&B.  This is because the groupCheckboxes function in SpecialUserrights.php calls htmlspecialchars on the group name and then calls Xml::checkLabel which does another htmlspecialchars.

I haven't tested this on 1.16.5 but a quick glance at the code shows that the problem still exists in trunk.
Comment 1 Brion Vibber 2011-06-10 18:03:52 UTC 
Group names are expected to be plaintext, I think...
Comment 2 Christian Neubauer 2011-06-13 11:33:35 UTC 
Seems like the code should either not allow group names with entities or display them correctly.  Incidentally, group names with entities works fine everywhere else.
Comment 3 Mark A. Hershberger 2011-06-14 21:29:50 UTC 
(In reply to comment #1)
> Group names are expected to be plaintext, I think...

So, is this WONTFIX or ... ?
Comment 4 Brion Vibber 2011-09-22 00:49:05 UTC 
Hmm, I think the correct action would be 'validate group names'. A central place to validate the names, and calling that to check on various group-related entry points, should show up bad entries pretty quick.

If there's any UI allowing to create or specify group names by hand those should call the validation as well.
Comment 5 Christian Neubauer 2012-03-09 11:27:09 UTC 
Another place these group names doesn't work is on Special:Statistics.  You get no results for users in that group.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links